Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chaitali/create client #4793

Merged
merged 7 commits into from
Mar 9, 2021
Merged

Chaitali/create client #4793

merged 7 commits into from
Mar 9, 2021

Conversation

chaitali-mane
Copy link
Contributor

🔩 Description: What code changed, and why?

We need to add the UI for the create client using the modal.

⛓️ Related Resources

#4568

👍 Definition of Done

I have added create data bag modal and some other changes to create the data bag.

👟 How to Build and Test the Change

Go to the infrastructure tab from the top navigation bar then you can see the Chef Server
If you have data then you can see the list of servers --> click to any server ---> you can see the list of orgs --> click to any org ---> you can see the multiple tabs after clicking on org (Cookbooks, Roles, Environments, Data Bags, Clients)
click to the Clients tab and you can see the Create Client button.

✅ Checklist

📷 Screenshots, if applicable

create-client-btn

create-client-modal

@netlify
Copy link

netlify bot commented Mar 4, 2021

Deploy preview for chef-automate processing.

Building with commit 80c17aa

https://app.netlify.com/sites/chef-automate/deploys/60429240a2577f000736815c

Copy link
Contributor

@tarablack01 tarablack01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
@kalroy kalroy self-requested a review March 9, 2021 09:14
Copy link
Collaborator

@kalroy kalroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in local... working fine!!

@kalroy kalroy merged commit bfddae3 into master Mar 9, 2021
@kalroy kalroy deleted the Chaitali/create_client branch March 9, 2021 09:16
@chaitali-mane
Copy link
Contributor Author

chaitali-mane commented Mar 10, 2021

While acceptance testing, observed
1.Create Button alignment disturbed
2. On open modal focus should be on first text box
will cover in #4808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants